Improve dark theme surface colour blending #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adjusts some of the surface colours for the dark theme to better match the previous versions (v0.5.1). For some context, the
flex_color_schemeupdate changed some of the surface colours to be darker. This change aims to match the colours more closely (although it won't be identical due to all the changes from Flutter's side)Note: I'm not quite sure if the light mode was affected in any way, so no changes were applied there. Additionally, I'm not entirely sure how enabling Material You changes the look of the surface colours so I applied a bit of primary colour blending.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?